Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654374 Ralf Corsepius <rc040203@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@xxxxxxxxxx --- Comment #11 from Ralf Corsepius <rc040203@xxxxxxxxxx> 2010-11-27 01:20:56 EST --- Not a formal review, just some comments. * I am not sure whether bundling this sample-map is a good idea, because most users will want to remove it and replace it with a map which suites their needs i.e. I'd propose to either * entirely remove this map from this package. * package it as a separate package. * package it as a "noarch" subpackage of navit. * I am observing an inpressive amount of warnings when running navit, similar to this one: navit:displayitem_draw:failed to load icon '/usr/share/navit/xpm/parking.png' * Your package contains a larger number of *la's. Are they really needed? I haven't checked, but I am having doubts. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review