Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=656938 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxxxxx> 2010-11-26 16:01:03 EST --- * rpmlint clean * sources: OK $ md5sum *.gz 2cd0bab00a2c39d1ae6cd9ed648db904 Shapely-1.2.7.tar.gz * naming ok * license ok * installs/runs ok (performed only very basic tests) * %files ok (but see next...) * SHOULD: please document why %exclude %{_bindir}/intersect.py %exclude %{_bindir}/dissolve.py * SHOULD: consider adding a %check section with: $ python setup.py test fwiw, I see 3 failures on my f14 box (once I installed numpy), though at least one is due to some slight rounding differences. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review