[Bug 657040] Review Request: tudu - A simple, command line interface to do list application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657040

--- Comment #9 from Ken Nelson <nelsoninva@xxxxxxxxx> 2010-11-26 09:13:16 EST ---
The Makefile under src in the tarball needs to be patched.  My effort is rather
ham-fisted, but succeeds in quieting rpmlint on the debug package.
I applied this patch(Patch1) to src/Makefile:

diff --git a/Makefile b/Makefile
index 4a139fc..504854c 100644
--- a/Makefile
+++ b/Makefile
@@ -2,7 +2,7 @@ PROG=tudu
 SRCS=tudu.cc data.cc editor.cc interface.cc window.cc text.cc parser.cc
 SRCS+= config.cc date.cc screen.cc sched.cc cmd.cc
 CXX=g++
-CFLAGS=-Wall -O2 -DSHARE_DIR=\"$(SHARE_DIR)\" -DETC_DIR=\"$(ETC_DIR)\"
+CFLAGS+= -DSHARE_DIR=\"$(SHARE_DIR)\" -DETC_DIR=\"$(ETC_DIR)\"

 OBJS=$(SRCS:.cc=.o)

And then changed the prep section in the specfile to look like this:
%prep
%setup -q
%patch0 -p1
pushd src
%patch1 -p1
sed -i -e "1 i \
CFLAGS=%{optflags}
" Makefile
popd

---
And, after an rpmbuild, I have:
[knelson@zonker SPECS]$ rpmlint
/home/knelson/rpmbuild/RPMS/x86_64/tudu-debuginfo-0.7-2.fc14.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

which is the desired result.  I have zero doubt that there are vastly better
ways to change the Makefile than my clumsy attempt outlined above; I look
forward to seeing what those ways are, so I can further my education.

-k-

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]