Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=653435 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2010-11-24 13:12:21 EST --- Source file original. Ok. Summary verified from lib/Catalyst/Engine/PSGI.pm. Ok. License verfied from lib/Catalyst/Engine/PSGI.pm. Ok. FIX: BuildRequire perl(File::Spec) as it can dual-live in the future (lib/Catalyst/Helper/PSGI.pm:4, http://search.cpan.org/~smueller/PathTools/) FIX: BuildRequire perl(Moose) (lib/Catalyst/Engine/PSGI.pm:7:use Moose) FIX: BuildRequire perl(Scalar::Util) as it can dual-live in the future (lib/Catalyst/Engine/PSGI.pm:20, http://search.cpan.org/~gbarr/Scalar-List-Utils/) FIX: BuildRequire perl(URI) (lib/Catalyst/Engine/PSGI.pm:21) FIX: BuildRequire perl(MyApp) (lib/Catalyst/Engine/PSGI.pm:210) Tests dependencies: FIX: BuildRequire perl(Plack::Loader) (lib/Plack/Test/Adopt/Catalyst.pm:9) FIX: BuildRequire perl(Test::More) (t/hello.t:2) FIX: BuildRequire perl(Test::Requires) (t/hello.t:3) FIX: BuildRequire perl(lib) as it can dual-live in the future (t/hello.t:4, http://search.cpan.org/~smueller/lib/) FIX: BuildRequire perl(LWP::UserAgent) (t/hello.t:6) FIX: BuildRequire perl(Catalyst) (t/catalyst/lib/TestAppChainedAbsolutePathPart.pm:4) FIX: BuildRequire perl(Catalyst::Utils) (t/catalyst/lib/TestAppChainedAbsolutePathPart.pm:8) FIX: BuildRequire perl(Moose::Utils) (t/catalyst/lib/TestApp/Controller/Anon.pm:13) FIX: BuildRequire perl(namespace::clean) (t/catalyst/lib/TestApp/Controller/Moose.pm:5) FIX: BuildRequire perl(MooseX::MethodAttributes) (t/catalyst/lib/TestApp/Controller/Moose.pm:8) FIX: BuildRequire perl(Moose::Role) (t/catalyst/lib/TestApp/Controller/Immutable/HardToReload.pm:2) FIX: BuildRequire perl(YAML) (t/catalyst/lib/TestApp/Controller/Fork.pm:11) FIX: BuildRequire perl(HTML::Entities) (t/catalyst/lib/TestApp/Controller/Action/Chained.pm:6) FIX: BuildRequire perl(Data::Dumper) (t/catalyst/lib/TestApp/View/Dump.pm:6) FIX: BuildRequire perl(MRO::Compat) (t/catalyst/lib/CDICompatTestPlugin.pm:18) FIX: BuildRequire perl(FindBin) (t/catalyst/aggregate/live_component_controller_action_begin.t:6) FIX: BuildRequire perl(Benchmark) (t/catalyst/aggregate/live_component_controller_action_begin.t:17) FIX: BuildRequire perl(Catalyst::Request) (t/catalyst/aggregate/live_engine_request_uploads.t:12) FIX: BuildRequire perl(Catalyst::Request::Upload) (t/catalyst/aggregate/live_engine_request_uploads.t:13) FIX: BuildRequire perl(HTTP::Body::OctetStream) (t/catalyst/aggregate/live_engine_request_uploads.t:14) FIX: BuildRequire perl(HTTP::Headers) (t/catalyst/aggregate/live_engine_request_uploads.t:15) FIX: BuildRequire perl(HTTP::Headers::Util) (t/catalyst/aggregate/live_engine_request_uploads.t:16) FIX: BuildRequire perl(HTTP::Request::Common) (t/catalyst/aggregate/live_engine_request_uploads.t:17) FIX: BuildRequire perl(Path::Class::Dir) (t/catalyst/aggregate/live_engine_request_uploads.t:18) FIX: BuildRequire perl(CGI::Simple::Cookie) (t/catalyst/aggregate/live_engine_request_cookies.t:13) FIX: BuildRequire perl(Getopt::Long) (t/Hello/script/hello_fastcgi.pl:7) FIX: BuildRequire perl(Pod::Usage) (t/Hello/script/hello_fastcgi.pl) FIX: BuildRequire perl(Catalyst::Engine::HTTP) (t/Hello/script/hello_server.pl:6) FIX: BuildRequire perl(Catalyst::Restarter) (t/Hello/script/hello_server.pl) FIX: BuildRequire perl(Test::Pod::Coverage) >= 1.04 (t/Hello/t/03podcoverage.t:6) Description verified from lib/Catalyst/Engine/PSGI.pm. Ok. FIX: Duplicate `Changes' and `README' files in %doc. All compulsory tests pass. Ok. $ rpmlint perl-Catalyst-Engine-PSGI.spec ../SRPMS/perl-Catalyst-Engine-PSGI-0.11-1.fc14.src.rpm ../RPMS/noarch/perl-Catalyst-Engine-PSGI-* perl-Catalyst-Engine-PSGI.spec: W: no-buildroot-tag perl-Catalyst-Engine-PSGI.src: W: no-buildroot-tag perl-Catalyst-Engine-PSGI-tests.noarch: W: no-documentation perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script /usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/script/hello_create.pl 0644L /usr/bin/env perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script /usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/script/hello_server.pl 0644L /usr/bin/env perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script /usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/Makefile.PL 0644L /usr/bin/env perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script /usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/script/hello.psgi 0644L /usr/bin/env perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script /usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/script/hello_test.pl 0644L /usr/bin/env perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script /usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/script/hello_cgi.pl 0644L /usr/bin/env perl-Catalyst-Engine-PSGI-tests.noarch: E: non-executable-script /usr/libexec/perl5-tests/Catalyst-Engine-PSGI/t/Hello/script/hello_fastcgi.pl 0644L /usr/bin/env 3 packages and 1 specfiles checked; 7 errors, 3 warnings. FIX: permissions in perl-Catalyst-Engine-PSGI-tests.noarch $ rpm -pqlv ../RPMS/noarch/perl-Catalyst-Engine-PSGI-0.11-1.fc14.noarch.rpm drwxr-xr-x 2 root root 0 lis 24 18:53 /usr/share/doc/perl-Catalyst-Engine-PSGI-0.11 -rw-r--r-- 1 root root 1161 Äec 30 21:50 /usr/share/doc/perl-Catalyst-Engine-PSGI-0.11/Changes -rw-r--r-- 1 root root 563 zÃÅ 6 2009 /usr/share/doc/perl-Catalyst-Engine-PSGI-0.11/README -rw-r--r-- 1 root root 2033 lis 24 18:53 /usr/share/man/man3/Catalyst::Controller::Metal.3pm.gz -rw-r--r-- 1 root root 2739 lis 24 18:53 /usr/share/man/man3/Catalyst::Engine::PSGI.3pm.gz -rw-r--r-- 1 root root 1931 lis 24 18:53 /usr/share/man/man3/Catalyst::Helper::PSGI.3pm.gz -rw-r--r-- 1 root root 1877 lis 24 18:53 /usr/share/man/man3/Plack::Test::Adopt::Catalyst.3pm.gz drwxr-xr-x 2 root root 0 lis 24 18:53 /usr/share/perl5/Catalyst drwxr-xr-x 2 root root 0 lis 24 18:53 /usr/share/perl5/Catalyst/Controller -rw-r--r-- 1 root root 1015 pro 11 2009 /usr/share/perl5/Catalyst/Controller/Metal.pm drwxr-xr-x 2 root root 0 lis 24 18:53 /usr/share/perl5/Catalyst/Engine -rw-r--r-- 1 root root 7055 Äec 30 21:50 /usr/share/perl5/Catalyst/Engine/PSGI.pm drwxr-xr-x 2 root root 0 lis 24 18:53 /usr/share/perl5/Catalyst/Helper -rw-r--r-- 1 root root 913 dub 8 2010 /usr/share/perl5/Catalyst/Helper/PSGI.pm drwxr-xr-x 2 root root 0 lis 24 18:53 /usr/share/perl5/Plack drwxr-xr-x 2 root root 0 lis 24 18:53 /usr/share/perl5/Plack/Test drwxr-xr-x 2 root root 0 lis 24 18:53 /usr/share/perl5/Plack/Test/Adopt -rw-r--r-- 1 root root 1973 ÅÃj 13 2009 /usr/share/perl5/Plack/Test/Adopt/Catalyst.pm File layout and permissions Ok. $ rpm -pq --requires ../RPMS/noarch/perl-Catalyst-Engine-PSGI-0.11-1.fc14.noarch.rpm | sort | uniq -c 1 perl(App::Prove) 1 perl(Catalyst::Action::RenderView) 1 perl(Catalyst::Controller::Metal) 1 perl(Catalyst::Engine::PSGI) 1 perl(Catalyst::Runtime) >= 5.80007 1 perl(Class::MOP) 1 perl(File::Spec) 1 perl(Filter::Util::Call) 1 perl(:MODULE_COMPAT_5.12.2) 1 perl(Moose) 1 perl(Plack::Loader) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Test::TCP) 1 perl(URI) 1 perl(warnings) 1 perl >= 0:5.008_001 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 2 rpmlib(VersionedDependencies) <= 3.0.3-1 $ rpm -pq --provides ../RPMS/noarch/perl-Catalyst-Engine-PSGI-0.11-1.fc14.noarch.rpm | sort | uniq -c 1 perl(Catalyst::Controller::Metal) 1 perl(Catalyst::Engine::PSGI) = 0.11 1 perl-Catalyst-Engine-PSGI = 0.11-1.fc14 1 perl(Catalyst::Helper::PSGI) 1 perl(Plack::Test::Adopt::Catalyst) FIX: perl(Plack::Loader) symbol is not provided by any package in F-15. $ rpm -pq --requires ../RPMS/noarch/perl-Catalyst-Engine-PSGI-tests-0.11-1.fc14.noarch.rpm | sort | uniq -c 1 perl-Catalyst-Engine-PSGI = 0.11-1.fc14 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 /usr/bin/prove $ rpm -pq --provides ../RPMS/noarch/perl-Catalyst-Engine-PSGI-tests-0.11-1.fc14.noarch.rpm | sort | uniq -c 1 perl-Catalyst-Engine-PSGI-tests = 0.11-1.fc14 Binary dependencies Ok. Package builds in F-15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2621855). Ok. Otherwise package is in line with Fedora and perl packaging guidelines. Please correct all `FIX' prefix issues and provide new spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review