Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Structures-DataGrid-DataSource-Array - DataSource driver using arrays Alias: pear-DG-Array https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212924 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-12-02 14:45 EST ------- The by now standard rpmlint complaints: W: php-pear-Structures-DataGrid-DataSource-Array no-documentation W: php-pear-Structures-DataGrid-DataSource-Array filename-too-long-for-joliet php-pear-Structures-DataGrid-DataSource-Array-0.1.0-1.fc7.noarch.rpm There's really just a single 4K file here; not much to review, really. * source files match upstream: 9f9a76d291ee8d99134c71173bb84bdb Structures_DataGrid_DataSource_Array-0.1.0.tgz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: php-pear(Structures_DataGrid_DataSource_Array) = 0.1.0 php-pear-Structures-DataGrid-DataSource-Array = 0.1.0-1.fc7 = /bin/sh /usr/bin/pear php-pear(PEAR) php-pear(Structures_DataGrid) * %check is not present; no test suite upstream. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets OK (pear module installation) * code, not content. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review