Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=650604 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> 2010-11-22 06:54:20 EST --- I asked Fedora Packaging Committee to explain it: <https://fedorahosted.org/fpc/ticket/36>. As spec file is old, I used the one from SRPM. Spec file changes: --- perl-PDF-Haru.spec.old 2010-11-07 13:12:01.000000000 +0100 +++ perl-PDF-Haru.spec 2010-11-22 12:41:46.058735112 +0100 @@ -1,6 +1,6 @@ Name: perl-PDF-Haru Version: 1.00 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Perl interface to Haru Free PDF Library Group: Development/Libraries @@ -9,6 +9,10 @@ Source0: http://search.cpan.org/CPAN/authors/id/B/BU/BUTILW/PDF-Haru-%{version}.tar.gz BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) +BuildRequires: perl(Exporter) +BuildRequires: perl(AutoLoader) +Buildrequires: perl(XSLoader) +Buildrequires: perl(constant) BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(Test::More) BuildRequires: libharu-devel @@ -30,6 +34,7 @@ %prep %setup -q -n PDF-Haru-%{version} +chmod -x examples/*.pl %build @@ -62,5 +67,9 @@ %changelog +* Fri Nov 19 2010 Robin Lee <cheeselee@xxxxxxxxxxxxxxxxx> - 1.00-2 +- BR: perl(Exporter), perl(AutoLoader), perl(XSLoader) and perl(constant) added +- Removed executable bits from examples/*.pl scripts + * Sun Nov 7 2010 Robin Lee <cheeselee@xxxxxxxxxxxxxxxxx> - 1.00-1 - Initial packaging > > FIX: BuildRequire perl(Exporter) explicitly as it can dual-live in > > standalone package in the future (lib/PDF/Haru.pm:8, > > http://search.cpan.org/~ferreira/Exporter/). > > > > FIX: BuildRequire perl(Autoloader) explicitly as it can dual-live in > > standalone package in the future (lib/PDF/Haru.pm:9, > > http://search.cpan.org/~smueller/AutoLoader/). > > > > FIX: BuildRequire perl(XSLoader) explicitly as it can dual-live in > > standalone package in the future (lib/PDF/Haru.pm:172, > > http://search.cpan.org/~saper/XSLoader/). > > > > FIX: BuildRequire perl(constant) explicitly as it can dual-live in > > standalone package in the future (lib/PDF/Haru.pm:177, > http://search.cpan.org/~saper/constant/). > +BuildRequires: perl(Exporter) > +BuildRequires: perl(AutoLoader) > +Buildrequires: perl(XSLoader) > +Buildrequires: perl(constant) Ok. > > FIX: Remove executable bit from examples/* files (put chmod into %prep > > section). > +chmod -x examples/*.pl Ok. $ rpmlint perl-PDF-Haru.spec ../SRPMS/perl-PDF-Haru-1.00-2.fc14.src.rpm ../RPMS/x86_64/perl-PDF-Haru-1.00-2.fc14.x86_64.rpm perl-PDF-Haru.src: W: spelling-error %description -l en_US encodings -> encoding, encoding s, encodes perl-PDF-Haru.x86_64: W: spelling-error %description -l en_US encodings -> encoding, encoding s, encodes 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint Ok. Package builds in F-15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2615655). Ok. Package is in line with Fedora and perl packaging guidelines. Resolution: Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review