Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alphabet-soup - Guide your worm through the soup to spell words Alias: alphabet-soup https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218023 ------- Additional Comments From chris.stone@xxxxxxxxx 2006-12-01 12:26 EST ------- ==== REVIEW CHECKLIST ==== - rpmlint output clean - package named according to package naming guidelines - spec file name matches %{name} - meets packaging guidelines - licensed with open source compatible license - license field matches actual license - license file included in %doc - spec written in American english - spec legible - sources match upstream: 364fe30c53a86217db37f53308604f74 as11src.zip - successfully compiles and builds on FC6 x86_64 X missing BR: dumb-devel - no locales - no shared libraries - package is not relocatable - package owns all directories it creates X package uses directory not pulled in through Requires must require hicolor-icons - no duplicates in %files - file permissions set properly - contains proper %clean - macro usage consistent - contains code - no large documentation - %doc does not affect runtime - no header files or static libraries - no pkgconfig files - no need for devel subpackage - no .la files - contains proper .desktop file - does not own files or directories owned by other packages ==== MUST FIX ==== - Add dumb-devel to BR - requires hicolor-icon-theme package -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review