Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571993 --- Comment #14 from Orcan Ogetbil <oget.fedora@xxxxxxxxx> 2010-11-21 23:15:24 EST --- Sorry for being late. Here is a more thorough review: - rpmlint says non-sequencer.src:61: W: configure-without-libdir-spec non-sequencer.src: W: invalid-url Source0: non-sequencer-20100131gitba94d2c354145.tar.bz2 non-sequencer.x86_64: W: no-manual-page-for-binary non-sequencer These can be ignored. However non-sequencer.x86_64: W: no-documentation needs a fix. You need to put at least the COPYING file in this package, also possibly the TODO file ! Currently, the -doc subpackage does not require the main package. Is this intentional? If this is what you want, the COPYING file must exist both in the main package and the -doc subpackage. * Currently the source tarball contains the .git* stuff that we don't need. Those can be taken out. The tarball instructions tarball tell us to check out the latest git version. What we need is the instructions to generate the exact tarball. In case upstream updates their repo, current instructions will be incorrect. * The %doc package should be noarch * Please explain in the SPEC file where you got the other sources. Do they have copyrights? Also please explain in the SPEC file what the patch is for, and/or its upstream status. * The directory %{_datadir}/%{name}/ must be owned by the main package. See http://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership * You certainly don't need the BuildRequires: cmake git. I am not sure whether you really need libpng-devel libjpeg-devel. Somehow -lpng and -ljpeg flags are passed to the linking, but what adds them? * Each package must consistently use macros. Please don't use plain /usr. Use %{_prefix} instead. ! Please span %description to 80 columns as much as possible. Currently it is set to 70. * The icon is installed in the wrong place. It should be %{_datadir}/icons/hicolor/128x128/apps/ Note that you leave the scriptlets as is. ? sed -i "/\.html/d" Makefile What is the above for? Can't that be moved to %prep? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review