Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654909 --- Comment #4 from Kevin Fenzi <kevin@xxxxxxxxx> 2010-11-21 13:31:18 EST --- Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [1] [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Spec file is legible and written in American English. [x] Spec file lacks Packager, Vendor, PreReq tags. [x] Spec uses macros instead of hard-coded directory names. [x] Package consistently uses macros. [x] Macros in Summary, %description expandable at SRPM build time. [x] PreReq is not used. [x] Requires correct, justified where necessary. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [2] [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)). [x] Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the beginning of %install. [x] Package use %makeinstall only when ``make install DESTDIR=...'' doesn't work. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] The spec file handles locales properly. [x] Changelog in prescribed format. [!] Rpmlint output is silent. [x] License field in the package spec file matches the actual license. [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] License file installed when any subpackage combination is installed. [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [3,4] [x] Sources contain only permissible code or content. [!] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : 99bf7894c17a3312cdf634bb17b6eb4b MD5SUM upstream package : 457973f47ac0cf3fc843fbd24ece9846 [?] Compiler flags are appropriate. [?] %build honors applicable compiler flags or justifies otherwise. [?] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package does not own files or directories owned by other packages. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Each %files section contains %defattr. [?] No %config files under /usr. [?] %config files are marked noreplace or the reason is justified. [?] Package contains a properly installed %{name}.desktop using desktop-file-install file if it is a GUI application. [5] [?] Package contains a valid .desktop file. [x] Package contains code, or permissable content. [?] Package contains a SysV-style init script if in need of one. [!] File names are valid UTF-8. [?] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [x] Package contains no bundled libraries. [x] Package does not genrate any conflict. [x] Package does not contains kernel modules. [x] Package is not relocatable. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. [x] Package is not known to require ExcludeArch. [x] Package installs properly. [x] Package obeys FHS, except libexecdir and /usr/target. [x] Package meets the Packaging Guidelines. [6] === SUGGESTED ITEMS === [?] Package functions as described. [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [x] If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [?] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!] SourceX is a working URL. [!] SourceX / PatchY prefixed with %{name}. [x] Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [!] %check is present and all tests pass. [x] Reviewer should test that the package builds in mock. [x] Package should compile and build into binary rpms on all supported architectures. [x] Dist tag is present. [x] Spec use %global instead of %define. [x] Scriptlets must be sane, if used. [x] No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x] Packages should try to preserve timestamps of original installed files. [x] Uses parallel make. === Issues === 1. rpmlint says: django-tables.noarch: E: zero-length /usr/lib/python2.7/site-packages/django_tables/app/models.py I assume that 0 len file is usefull for something? django-tables.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/django-tables-0.2/README If you want to fix this with a sed command, that might be nice. django-tables.src: W: invalid-url Source0: django-tables-0.2.tar.gz Should be fine since you explain how to check out the source. No chance upstream will release a real tar? 2. The md5 doesn't match upstream, but thats due to it being a source checkout. I did a checkout of each and a diff on the entire tree and the only differences were timestamp related. (not a blocker) 3. There are some tests available in a test directory. Is it practical to run those in a %check section here? (If they need internet access or something you shouldn't enable them at build time, but if they don't it would be nice to run them) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review