Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=655379 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-review? --- Comment #1 from Hans de Goede <hdegoede@xxxxxxxxxx> 2010-11-21 05:31:03 EST --- Full review done: Good: - rpmlint checks return: tritonus.src: W: invalid-url Source0: tritonus-0.3.7-20101108cvs.tar.bz2 tritonus-esd.x86_64: W: spelling-error Summary(en_US) javax -> java, java x, Javan tritonus-esd.x86_64: W: spelling-error Summary(en_US) libesd -> libelous, libelist, libero tritonus-esd.x86_64: W: spelling-error %description -l en_US javax -> java, java x, Javan tritonus-esd.x86_64: W: spelling-error %description -l en_US libesd -> libelous, libelist, libero tritonus-javadoc.x86_64: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Javanese tritonus-src.x86_64: W: only-non-binary-in-usr-lib tritonus-src.x86_64: W: no-documentation 8 packages and 0 specfiles checked; 0 errors, 8 warnings. The first 6 can be ignored, the last 2 go away once the -src package is folded into the main package (see below). - package meets naming guidelines - package meets packaging guidelines - license (LGPLv2+) OK, text in %doc, matches source Note the gsm code is an exception license wise, see below. - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - nothing in %doc affects runtime - no need for .desktop file Needs work: - Please remove the following no longer valid comment from the specfile: # The following circular dependencies are intentional. These classes need each other. - Please fix the indentation of the following provides to be like that of the other provides / tags: Provides: %{name}-shared = %{version}-%{release} - Please fold the -src subpackage into the main package (it is tiny and brings in no external dependencies) - Please re-introduce the -gsm subpackage, sorry about this, but the gsm java code is licensed under the GPLv2+, rather then the LGPLv2+, so it needs to be packaged separately. Do not forget to add a: License: GPLv2+ line to the subpackage -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review