Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=654544 HaÃkel GuÃmar <karlthered@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from HaÃkel GuÃmar <karlthered@xxxxxxxxx> 2010-11-19 16:58:32 EST --- According to python packaging guidelines [1], python2 modules should set BR to python2-devel (actual python-devel packages provides both). Though it's not (yet?) mandatory, i recommend you set BR to python2-devel instead of python-devel for F13+ [2]. But it's up to you and should not block the review. The same goes for the license file, since it has already been fixed upstream, it could wait the next release. I hereby approve python-asyncmongo into fedora packages collection. [1] http://fedoraproject.org/wiki/Packaging:Python#BuildRequires [2] if you plan to maintain EPEL branches, ask EPEL guys first -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review