Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=653682 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #8 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-11-18 12:47:11 EST --- Hi Ingvar, you should have bumped the Release number. ;-) Besides that, the package looks fine now, and we can finish here. $ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm jemalloc.src: W: spelling-error Summary(en_US) malloc -> mallow, Mallorca, Mallory jemalloc.src: W: spelling-error %description -l en_US malloc -> mallow, Mallorca, Mallory jemalloc.x86_64: W: spelling-error Summary(en_US) malloc -> mallow, Mallorca, Mallory jemalloc.x86_64: W: spelling-error %description -l en_US malloc -> mallow, Mallorca, Mallory jemalloc-devel.x86_64: W: manual-page-warning /usr/share/man/man3/jemalloc.3.gz 65: warning: macro `UR' not defined jemalloc-devel.x86_64: W: manual-page-warning /usr/share/man/man3/jemalloc.3.gz 67: warning: macro `UE' not defined 4 packages and 0 specfiles checked; 0 errors, 8 warnings. The above warnings can savely be ignored: - spelling errors are false positive - undefined groff macros UR/UE don't harm the proper display of the manpage --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. BSD (2- and 3-clause variants) [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum jemalloc-2.0.1.tar.bz2* 4687f59c073975f39375ece49c402bdc jemalloc-2.0.1.tar.bz2 4687f59c073975f39375ece49c402bdc jemalloc-2.0.1.tar.bz2.1 [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2608809 [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [.] MUST: All build dependencies must be listed in BuildRequires. - none required [.] MUST: The spec file MUST handle locales properly. [+] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [+] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [+] MUST: library files with a suffix must go in a -devel package. [+] MUST: devel packages must require the base package using a fully versioned dependency [+] MUST: Packages must NOT contain any .la libtool archives [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) ... [+] SHOULD: The reviewer should test that the package builds in mock. [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [+] SHOULD: The reviewer should test that the package functions as described. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: subpackages other than devel should require the base package [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [+] SHOULD: your package should contain man pages for binaries/scripts. ---------------- Package APPROVED ---------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review