Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608332 --- Comment #4 from Michael J Gruber <mjg@xxxxxxxxxxxxxxxxx> 2010-11-18 11:42:14 EST --- (In reply to comment #3) > Actually rpmlint output is > rootplot.noarch: E: explicit-lib-dependency python-matplotlib > rootplot.noarch: W: spelling-error Summary(en_US) matplotlib -> matelote, > matrilocal, marplot > rootplot.noarch: W: spelling-error %description -l en_US pyROOT -> pyrostat, > pyrope, pyrone > rootplot.noarch: W: spelling-error %description -l en_US matplotlib -> > matelote, matrilocal, marplot > rootplot.noarch: W: no-manual-page-for-binary rootplot > rootplot.noarch: W: no-manual-page-for-binary tree2hists > rootplot.src: W: spelling-error Summary(en_US) matplotlib -> matelote, > matrilocal, marplot > rootplot.src: W: spelling-error %description -l en_US pyROOT -> pyrostat, > pyrope, pyrone > rootplot.src: W: spelling-error %description -l en_US matplotlib -> matelote, > matrilocal, marplot > 2 packages and 0 specfiles checked; 1 errors, 8 warnings. On my side that was rpmlint on spec and srpm. Sorry. > > - Use macros rather than vars consistently (e.g. buildroot). > > Actually, the spec file does not mix styles. The only thing this applies is > using $RPM_OPT_FLAGS vs %{optflags} and $RPM_BUILD_ROOT vs %{buildroot}. The > choice between these is a matter of personal preference. It uses different styles for different variables ($RPM_BUILD_ROOT vs. %{_bindir}). If that's not a problem I'm fine with it. > > - Use %{python_sitelib}/root2matplotlib etc. so that you do not own all of > > sitelib. > > This is not a problem per se, the rootplot package only ends up owning the > directories that are in %{python_sitelib} *in the build root*. I've heard someone say - The %files section needs improvement. The statement %{python_sitearch}/ ends up owning the system python directory, which is not wanted. Is this different? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review