Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553649 Garrett Holmstrom <gholms@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |gholms@xxxxxxxxxxxxxxxxx --- Comment #3 from Garrett Holmstrom <gholms@xxxxxxxxxxxxxxxxx> 2010-11-16 18:59:56 EST --- I meant to come back to this one, but it somehow managed to slip through a crack somewhere. Sorry. I see only a couple minor issues at the moment, so just fix those up and you should be good to go. I will attach the full review shortly. - Changelog in prescribed format Please add a hyphen to the beginning of line 74. Sorry for nitpicking. ;-) - Requires correct, justified where necessary If you are building this against EL4 you should Require python with a versioned dependency, and then only after testing that you're building on < EL5. If you aren't building against EL4 then you should instead drop that Requires directive altogether since rpmbuild will pick that up on its own. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review