Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226419 Garrett Holmstrom <gholms@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Garrett Holmstrom <gholms@xxxxxxxxxxxxxxxxx> 2010-11-16 18:31:27 EST --- Below are the issues I found. I will attach a full review shortly. - License field in spec is correct sipgen/parser.c is GPLv3+ with exceptions sipgen/parser.h is GPLv3+ with exceptions A quick IRC discussion indicated that this likely needs to appear in the License field somewhere. I'm hoping spot gets back to me for confirmation about it to be sure, though perhaps it would be better to just ask legal to be extra certain. - License files installed when any subpackage combination is installed sip-macros package does not pull in license files It looks like you create macros.sip yourself based on the program's API version. What license does it have? Can you include that license along with the sip-macros package? - Sources match upstream unless altered to fix permissibility issues Upstream MD5: No longer on upstream's server Your MD5: 0a591ef6e59aa16e56822d3eb9fe21b8 sip-4.10.5.tar.gz Unfortunately, upstream seems to clean out old tarballs quite frequently. I wouldn't block the review because of that, though. - Each %files section contains %defattr The python3 packages lack %defattr macros Please add %defattr macros to the python3 packages' %files sections. I hope that helps! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review