Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634909 Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.badger@xxxxxxxxx --- Comment #8 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> 2010-11-16 15:49:28 EST --- I'm not committing to reviewing this but I noticed a couple things: 1) I see that we're installing jsmin.py... If this is a derivative of the jsmin stuff that Douglas Crockford did then we can't do that. jsmin is not under an fsf free license (the silly "must be used for good, not evil clause does that to us). 2) usually we don't make shared libraries if upstream is not making shared libraries due to being afraid that we'll choose a version that upstream will later stomp on. The same idea (upstream reusing the version number we use for a later, API incompatible, release of their own) would seem to apply here. However, I do see that Debian is providing versioned dynamic libs (Their patches are different, though... perhaps we should adopt their approach? http://packages.debian.org/experimental/libv8-2.4.7) The best outcome would be for upstream to start providing versioned dynamic libraries. Have you contacted them about this? The debian patches are to the build files so they could be an appropriate starting point for that discussion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review