Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=653378 --- Comment #2 from Matthias Clasen <mclasen@xxxxxxxxxx> 2010-11-16 09:13:09 EST --- package name: ok spec file name: ok packaging guidelines: minor issues: - the explicit dep on gtk3 should be dropped, since it will get pulled in by library deps anyway. - as mentioned, the .pc file needs to go in a -devel package (until we get rid of it upstream) license: ok license field: copying says GPLv3... license file: should be included, after verifying what license was intended here spec language: ok spec readable: ok upstream sources: ok buildable: ok excludearch: ok build requires: ok locale handling: ok ldconfig: ok system libraries: ok relocatable: ok directory ownership: must own %{_datadir}/gtk-theme-engine-clearlooks duplicate files: ok file permissions: ok macro use: ok permissible content: ok large docs: ok doc content: ok headers: ok static libs: ok shared libs: ok -devel deps: ok libtool archives: the .la file needs to be dropped gui apps: ok duplicate ownership: ok utf8 filenames: ok -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review