Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=612076 Jens Petersen <petersen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review?, needinfo+ |fedora-review+ --- Comment #11 from Jens Petersen <petersen@xxxxxxxxxx> 2010-11-15 04:35:00 EST --- Thanks for waiting patiently. BTW what is the roadmap for this package are there going to be other packages in fedora that will need it? Here is the review: +:ok, NA: not applicable MUST Items: [+] MUST: rpmlint output: ghc-feldspar-language.src: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum ghc-feldspar-language.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum ghc-feldspar-language-devel.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum ghc-feldspar-language-prof.x86_64: E: devel-dependency ghc-feldspar-language-devel ghc-feldspar-language-prof.x86_64: W: no-documentation ghc-feldspar-language-prof.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-6.12.3/feldspar-language-0.3.1/libHSfeldspar-language-0.3.1_p.a These are ok. [+] MUST: The package must be named according to the Package Naming Guidelines Naming follows Packaging:Haskell [+] MUST: The spec file name must match base package %{name} [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: include license files in %doc if included in source [+] MUST: The spec file must be written in American English and be legible. [+] MUST: source md5sum matches upstream release 4dc9ae8be2f0d20c8ba4d1b765250349 feldspar-language-0.3.1.tar.gz [+] MUST: must successfully compile and build into binary rpms on one main arch [+] MUST: if necessary use ExcludeArch for other archs [+] MUST: All build dependencies must be listed in BuildRequires [NA] MUST: use %find_lang macro for .po translations [NA] MUST: packages with shared library files in the dynamic linker's default paths, must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [NA] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review [+] MUST: A package must own all directories that it creates, or require a package which does create that directory. [+] MUST: A package must not contain any duplicate files in the %files listing (except license files if necessary). [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. [+] MUST: Each package must consistently use macros [+] MUST: The package must contain code, or permissable content. [NA] MUST: Large documentation files should go in a doc subpackage. [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+] MUST: Header files must be in a -devel package. [NA] MUST: Static libraries must be in a -static package. [NA] MUST: If a package has library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [+] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [+] MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec. [NA] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. SHOULD Items: [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [NA] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [NA] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. [NA] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. Any examples or test cases for how to use this library? Were you planning to submit feldspar-compiler too? Package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review