Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518636 Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #10 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxxxxxxxx> 2010-11-14 15:33:37 EST --- Hi Luca, Looks good -- with one minor glitch, that you can fix when importing the package: you have *two* %changelog section! Please rpmlint the .spec file when you make changes. Review is APPROVED, since the fix is trivial enough. And I've sponsored you. Please follow the next step in the review guidelines: 1. Change fedora-cvs flag to ? and create a new SCM request: http://fedoraproject.org/wiki/Package_SCM_admin_requests you only need to request the stable branches; 'master' targets Rawhide and you automatically get that For your next several packages, please put me in the InitialCc: list, and you're more than welcome to mail me with any packaging question or review requests. 2. Build package for Rawhide and other stable branches http://fedoraproject.org/wiki/Using_Fedora_GIT 3. Apart from el6 (which just went stable), the stable branches all required updates to be pushed through Bodhi; please create an update request for this package there: https://admin.fedoraproject.org/updates/new You can list the built packages for multiple distributions on the same form; they will share all properties (description, bugs closed, automatic push karma and automatic cancellation karma etc.) but will be partitioned based on the targeted release. Welcome to the packaging club :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review