Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652396 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-11-14 14:48:15 EST --- Some notes * Licensing - It seems that openhash/openhash.rb comes from hashery gem ( the latest version of hashery gem is 1.3.0). Also the license of lib/hashery/openhash.rb in hashery 1.3.0 is currently under ASL 2.0. - Would you tell me where openhash/openhash.rb (in boxgrinder-core gem) came from? - Also would you show us if the license of openhash.rb is really under MIT? - And. bundling files in other projects is generally forbidden and needs FPC's approval. Would you consider to package rubygem-hashery seperately? * BuildRoot line / %clean section - BuildRoot line is no longer needed on Fedora and EPEL6 - %clean section is no longer needed on Fedora 12+ and EPEL6. * Unneeded version specific dependency - " >= 1.2" part on "R: rubygems" or so are all unneeded ( Only that "= %{abi}" part on "R: ruby(abi)" is needed ) https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires ( Please see the last 2 sentences in this section ) * Output file on %check - If %check section produces some extra files, it is preferable that %check section won't touch %buildroot tree to avoid unneeded confusion on %files and will touch files under %_builddir ( i.e. In this case, it is preferable that gem is once installed under %_builddir and then copy the whole tree to %buildroot at %install, then execute %check under %_builddir) * Ability to build - Your srpm does not build on koji for dist-rawhide (at least). At least, "BR: rubygem(rake) rubygem(open4)" is needed (for %check) (and perhaps also rubygem(rspec)) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review