Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: v4l2-tool - Tool to get webcam usage Information https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208396 ------- Additional Comments From michel.salim@xxxxxxxxx 2006-11-29 16:15 EST ------- Need fixing: - rpmlint on SRPM: W: v4l2-tool mixed-use-of-spaces-and-tabs (spaces: line 10, tab: line 1) - v4l2-tool.png included twice (in /usr/share/pixmaps and /usr/share/pixmaps/v4l2-tool). I think one of them is meant to be v4l2-tool-logo.png, which is not packaged - dl.sourceforge.net has been refusing connections for some time. Change URL to use one of the download mirrors? - License file (COPYING) needs to be included in %docs - %description incorrect (says it's digiKam-doc) - desktop file's Categories should probably include HardwareSettings (and perhaps Utility) and should not include Player. Not sure if the Audio category is necessary - I think of a webcam as primarily a video device. Good: - Source matches upstream - License OK - Spec readable, language OK The Icon= line in the desktop file does not need to specify an extension, by the way. Most desktop files omit this (perhaps to make a switch to SVG easier) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review