Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=652533 Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #8 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxxxxxxxx> 2010-11-14 08:18:32 EST --- That looks good. I normally use the exact version number (e.g. 1.03) but that's partly an artifact of generating the patches automatically (I'm attaching my patch-generating script here for reference). But as long as the version number is unambiguous that's good enough as a practice. Everything looks good. APPROVED. As before, add me to the Cc: list :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review