Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=549590 --- Comment #13 from Eric Christensen <eric@xxxxxxxxxxxxxxxxxxx> 2010-11-13 11:08:36 EST --- (In reply to comment #7) > FIX: The License field in the package spec file must match the actual license. > Source code indicates the following: > This program is free software: you can redistribute it and/or modify > it under the terms of the GNU General Public License as published by > the Free Software Foundation, either version 1,2,3 of the License, or > (at your option) any later version. > > Which would be GPL+ instead of GPLv2+ Fixed. > FIX: The sources used to build the package must match the upstream source, as > provided in the spec URL. Reviewers should use md5sum for this task. If no > upstream URL can be specified for this package, please see the Source URL > Guidelines for how to deal with this. > > I know what you did (repackaged as a tarball from the rar) but you need to tell > us how to recreate what you did so we can compare sources > http://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code > While that isn't exactly the situation here - it's pretty close. Yep, that makes sense. Done. > FIX: Packages must NOT bundle copies of system libraries. > > I am saying fix here because it bundles fonts. > http://fedoraproject.org/wiki/Shipping_fonts_in_Fedora_%28FAQ%29 Yep. ONE of those fonts is already in the repositories. I wonder if the rest of them should be. I've removed the fonts completely. > All of the example*.php, *.php, buildall.cmd, Sample/* belongs in %doc FIXED > > Fonts should exist, but symlink in system fonts (or some other means of > handling them) I wonder if a symlink even needs to be there. I've compiled without the symlink and I think we need to test to see where the fonts are being pulled. SRPM: http://sparks.fedorapeople.org/Packages/pChart/php-pChart-1.27d-4.fc14.src.rpm SPEC: http://sparks.fedorapeople.org/Packages/pChart/php-pChart.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review