Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487281 Ruediger Landmann <r.landmann@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(pahan@xxxxxxxxxxx | |fo) --- Comment #11 from Ruediger Landmann <r.landmann@xxxxxxxxxx> 2010-11-11 01:42:02 EST --- To start with, some comments about the spec file and RPM output. Could you please address these issues and rebuild the SRPM? General: * Release number doesn't match changelog * Unless you're planning to release this for EPEL, you don't need: - the BuildRoot tag - to clean the BuildRoot in %install - the %clean section * You already discussed the missing documentation in your original request and although this is unfortunate, I agree that this is not a blocker. (documentation warnings omitted in rpmlint comments below) rpmlint output: $ rpmlint SPECS/eGroupware.spec SPECS/eGroupware.spec:128: W: unversioned-explicit-obsoletes egw-pear SPECS/eGroupware.spec:128: W: unversioned-explicit-obsoletes eGroupware-egw-pear SPECS/eGroupware.spec: W: invalid-url Source5: egroupware_fedora.tar.bz2 0 packages and 1 specfiles checked; 0 errors, 3 warnings. ========================================================================== * Neither egw_pear nor eGroupware-egw-pear were ever packaged for Fedora, so I don't think we need the Obsoletes (nor the corresponding Provides). You also have the package obsoleting itself; I guess you meant egw_pear... * Does upstream not publish egroupware_fedora.tar.bz2 somewhere? Could you perhaps ask them if they would consider publishing it? ========================================================================== $ rpmlint SRPMS/eGroupware-1.6.003-10.fc14.src.rpm eGroupware.src: W: spelling-error Summary(en_US) php -> fp, pp, hp eGroupware.src: W: spelling-error Summary(ru) ÐÐÐÐÐÐ -> ÐÐÐÐÐÐ, ÐÐÐÐÐÑ, ÐÐÐÐÐÐÑÐ eGroupware.src: W: spelling-error %description -l en_US avalible -> av alible, av-alible, alible eGroupware.src: W: spelling-error %description -l ru based eGroupware.src: W: spelling-error %description -l ru ÑÑÐÐÐÑ -> ÑÑÐÐÐ, ÑÑÐÐÐÑ, ÐÑÐÐÐÑ eGroupware.src: W: spelling-error %description -l ru web eGroupware.src: W: spelling-error %description -l ru mail eGroupware.src: W: spelling-error %description -l ru core eGroupware.src: W: spelling-error %description -l ru ÐÐÐÐÐÐÐÑÑ -> ÐÐÐÐÐÐÐÐÑÑ, ÐÐÐÐÐÐÐÐÑ, ÐÐÐÐÐÐÑÐÑÑÑ eGroupware.src: W: spelling-error %description -l ru ÐÐÑÑÑÐÐÐÐÐÑÑ -> ÐÐ ÑÑÑÐÐÐÐÐÑÑ, ÑÑÑÐÐÐÐÐÑÑÑÑ, ÑÑÑÐÐÐÐÐÑÑ eGroupware.src:128: W: unversioned-explicit-obsoletes egw-pear eGroupware.src:128: W: unversioned-explicit-obsoletes eGroupware-egw-pear eGroupware.src: W: invalid-url Source5: egroupware_fedora.tar.bz2 1 packages and 0 specfiles checked; 0 errors, 13 warnings. ========================================================================== * I am happy to help with the English expression in the Summary and Description; I'll attach a patch to this bug shortly. I can't help with the Russian, though, so please check this! (all other spelling warnings omitted below). ========================================================================== eGroupware-core.noarch: E: zero-length /usr/share/egroupware/setup/lang/egw_eu.lang eGroupware-core.noarch: E: zero-length /usr/share/egroupware/setup/lang/egw_rw.lang eGroupware-core.noarch: E: zero-length /usr/share/egroupware/setup/lang/egw_uk.lang eGroupware-core.noarch: E: zero-length /usr/share/egroupware/setup/lang/egw_tr.lang eGroupware-core.noarch: E: zero-length /usr/share/egroupware/phpgwapi/js/fckeditor/editor/dialog/fck_spellerpages/spellerpages/blank.html eGroupware-core.noarch: E: zero-length /usr/share/egroupware/setup/lang/egw_el.lang eGroupware-core.noarch: E: zero-length /usr/share/egroupware/setup/lang/egw_da.lang eGroupware-core.noarch: W: non-conffile-in-etc /etc/cron.d/eGroupware ========================================================================== * You already discussed the zero-length files when you opened this request. Perhaps use something like "find -size 0" to detect and remove the empty files. If these languages are added later, we will no longer remove them, but we will also remove any other empty language files added in future. Refer to http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Zero_length_files * You also discussed /etc/cron.d/eGroupware -- I agree this is not a problem here. ========================================================================== eGroupware-gallery.noarch: W: dangling-relative-symlink /usr/share/egroupware/gallery/gallery2 ../../gallery2 ========================================================================== * You already discussed this symlink in the original request. ========================================================================== eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/bulix/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/includes/xml/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/blue/images/index.html eGroupware-phpsysinfo.noarch: E: non-executable-script /usr/share/egroupware/phpsysinfo/tools/MakeRelease.sh 0644L /bin/sh eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/kde/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/orange/images/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/black/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/includes/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/classic/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/wintendoxp/images/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/metal/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/bulix/images/index.html eGroupware-phpsysinfo.noarch: E: non-executable-script /usr/share/egroupware/phpsysinfo/tools/MakeCVS.sh 0644L /bin/sh eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/includes/mb/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/tools/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/classic/images/index.html eGroupware-phpsysinfo.noarch: E: non-executable-script /usr/share/egroupware/phpsysinfo/tools/GenerateCL.sh 0644L /bin/sh eGroupware-phpsysinfo.noarch: E: non-executable-script /usr/share/egroupware/phpsysinfo/tools/cvs2cl.pl 0644L /bin/sh eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/orange/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/typo3/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/includes/lang/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/includes/os/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/blue/index.html eGroupware-phpsysinfo.noarch: E: non-executable-script /usr/share/egroupware/phpsysinfo/tools/GenerateChangeLog.sh 0644L /bin/sh eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/typo3/images/bar_right.gif eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/aq/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/windows_classic/images/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/metal/images/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/images/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/black/images/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/typo3/images/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/aq/images/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/windows_classic/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/wintendoxp/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/sample/index.html eGroupware-phpsysinfo.noarch: E: zero-length /usr/share/egroupware/phpsysinfo/templates/kde/images/index.html ========================================================================== * Are all these empty index.html files are needed for anything? (perhaps to avoid 404 errors?) If they're not needed, please filter them out. * Should these scripts be executable? ========================================================================== 30 packages and 0 specfiles checked; 53 errors, 42 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review