Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=645761 Gianluca Sforna <giallu@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Gianluca Sforna <giallu@xxxxxxxxx> 2010-11-10 10:46:18 EST --- Just one minor thing. The new doc section includes INSTALL.txt; since installation is covered by rpm we don't usually package those files. Anyway, I think we're done here. Full review: * Package name is correct * spec file name correct * spec file is legible and in english * License field is correct and acceptable in Fedora * License text is included in package * sources match upstream * macros used consistently * Builds correctly in mock for F14 * rpmlint is silent APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review