Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=651097 Daiki Ueno <dueno@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |dueno@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |dueno@xxxxxxxxxx --- Comment #1 from Daiki Ueno <dueno@xxxxxxxxxx> 2010-11-10 04:14:30 EST --- Looks mostly OK. Here are some comments: 1. foundry name Probably better to prepend a foundry name: http://fedoraproject.org/wiki/Packaging:FontsPolicy#Naming Since there is already "levien-inconsolata-fonts", I would suggest "levien-museum-fonts". Perhaps you could try repo-font-audit. http://fedoraproject.org/wiki/Font_package_lifecycle#2.a 2. fontconfig priority Choose the right fontconfig priority: http://fedoraproject.org/wiki/Fontconfig_packaging_tips#ruleset-prefix 3. BuildRoot is not necessary since F-13 You can get rid of %clean and "rm -rf %{buildroot}" in %install. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review