Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648549 --- Comment #6 from GermÃn Racca <gracca@xxxxxxxxx> 2010-11-09 10:58:35 EST --- Hi Hans! Thanks very much for your explanations about rpmlint output. As I said above, there were some warnings/errors I didn't see before so I needed to see your comments about them. Now it is all clear for me...and you didn't sound grumpy, so don't worry about that :) Some items that remains to check now that you, as upstream, released a modified version. Some things like checksums didn't change because you only patched the original code. === REQUIRED ITEMS === [x] Package successfully compiles and builds into binary rpms on at least one supported architec ture. Tested on: x86_64 [x] Rpmlint output: spice-vdagent.src: W: spelling-error %description -l en_US uinput -> input, u input, sinciput spice-vdagent.x86_64: W: spelling-error %description -l en_US uinput -> input, u input, sinciput spice-vdagent.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/spice-vdagent.desktop spice-vdagent.x86_64: W: no-manual-page-for-binary spice-vdagentd spice-vdagent.x86_64: W: no-manual-page-for-binary spice-vdagent spice-vdagent.x86_64: W: service-default-enabled /etc/rc.d/init.d/spice-vdagentd spice-vdagent.x86_64: W: incoherent-subsys /etc/rc.d/init.d/spice-vdagentd $prog spice-vdagent.x86_64: W: service-default-enabled /etc/rc.d/init.d/spice-vdagentd === SUGGESTED ITEMS === [x] Reviewer should test that the package builds in mock. Tested on: x86_64 === Final Notes === 1. Now the real problem rpmlint detected is fixed and all those warnings were explained by you in a previous comment. 2. Now I was able to successfully build the package in mock. Therefore, your package is... ================ *** APPROVED *** ================ I have tried to be as much clear as I could, but my English is poor, so if something remained obscure please let me know. Also, I would like to hear from you how I have been doing in my first review, so I can continue reviewing other packages also. All the best, GermÃn. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review