[Bug 651123] Review Request: <sarGraphs> - <Graphical System Usage Web Interface.>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651123

Brendan Jones <brendan.jones.it@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan.jones.it@xxxxxxxxx

--- Comment #2 from Brendan Jones <brendan.jones.it@xxxxxxxxx> 2010-11-08 21:45:20 EST ---
Hi Jeffrey

your package will not build as it presently stands.

Please be sure to install rpmdevtools and follow all the guidelines here to
build your Fedora package:
http://fedoraproject.org/wiki/How_to_create_an_RPM_package
and here
http://fedoraproject.org/wiki/Packaging/Guidelines

A few things in particular:
- your LICENSE file in your source states GPLv2 whereas you have specified GPL
in the spec file
- you need to specify the full URL of your Source0
- your release number should start at 1 not 0
- you cannot unpack files into /opt when you are building packages in your spec
file (you should not be installing anything under /opt in any case). The line
'setup -q' will unpack the source named under Source0 for you into
~/rpmbuild/BUILD/%{name}-%{version} where your package is built. Everything in
the spec file is executed relative to here. In your case you could omit the
%build section and simply move the required files from this area to your
buildroot in your %install section.
- your %post is better suited to a README file
- you will also need to clean up your files section, including adding a %doc
line to include your license file and any other documents you wish to be
included in the package such as AUTHOR, README - refer to the links above

Once you've attacked those things and can successfully build your package using
rpmbuild be sure to run rpmlint against the generated src package and post thre
results back here.

hope that helps,

Brendan

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]