Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=646139 --- Comment #4 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-11-07 15:12:06 EST --- (In reply to comment #3) > thank you very much for your comments and remarks. I really appreciate your > help. You're welcome. > I updated the package and here are the new URLs OK, fine. The new package looks pretty clean now. Just two minor cosmetic issues: - I suggest to use the plural in the Summary (pattern => patterns). - Add a final dot to the %description. $ rpmlint /var/lib/mock/fedora-14-x86_64/result/*.rpm kxstitch.src: W: no-cleaning-of-buildroot %clean kxstitch.src: W: no-buildroot-tag kxstitch.src: W: no-%clean-section 3 packages and 0 specfiles checked; 0 errors, 3 warnings. These warnings can be ignored if you plan to maintain the package for Fedora only. However, EPEL <= 5 still requires the missing items mentioned above. > One thing is a little bit strange: I added the kernel-headers to the BRs > because otherwise the package could not be build in mock on my F13 machine. I > followed your advice and removed it and now it builds smoothly, however, I > tested it only on my F14 machine. Yes, these kind of things happen from time to time, and can't be reproduced later on. Anyway, the package builds fine for F13 too: http://koji.fedoraproject.org/koji/taskinfo?taskID=2584994 As you probably already know, joining the Fedora packager group isn't an automatic process but requires some initial work to convince a sponsor to approve you. It's important to familiarize yourself with the packaging guidelines and show it by doing some informal reviews of other packager's submissions. That's a crucial thing because you're allowed to formally review, packages once you're sponsored. And, of course, you shouldn't mess up your own packages. So you should know what you're doing. :) If you don't have a sponsor yet, I can sponsor you if you're willing to informally review two or three package submissions. Just choose an uncommented review request ticket (e.g. bug #634025) and comment on the packages according to the review guidelines: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines There are a lot of further things to consider, but these are the most important ones. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review