Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603481 --- Comment #24 from Mads Kiilerich <mads@xxxxxxxxxxxxx> 2010-11-07 07:54:09 EST --- (In reply to comment #23) Thanks for the review. But ... please comment on this: > FIX - MUST: sources do not match the upstream source by MD5 > > - Upstream: 8a265ce267ea6508d30db29fd3c3c037 > - SRPM: 1e64b766874966004c07db12fe73dde8 I get 1e64... for http://downloads.sourceforge.net/freerdp/freerdp-0.8.1.tar.gz no matter what I do. How/where do you get 8a26...? > FIX - SHOULD: -devel package contains a pkgconfig(.pc) files must 'Requires: > pkgconfig'. AFAICS the following says that new packages shouldn't require it explicitly. http://fedoraproject.org/wiki/Packaging:Guidelines#Pkgconfig_Files (http://fedoraproject.org/wiki/PackagingDrafts/PkgconfigAutoRequires) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review