Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635382 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> 2010-11-05 08:45:33 EDT --- Spec file changes: --- perl-Tk-Text-SuperText.spec 2010-11-04 10:42:26.064373458 +0100 +++ perl-Tk-Text-SuperText.spec.1 2010-11-05 10:42:16.000000000 +0100 @@ -1,6 +1,6 @@ Name: perl-Tk-Text-SuperText Version: 0.9.4 -Release: 2%{?dist} +Release: 3%{?dist} Summary: Improved text widget for perl/tk License: GPL+ or Artistic Group: Development/Libraries @@ -11,6 +11,8 @@ BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildArch: noarch BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(Tk) +BuildRequires: perl(Tk::Derived) BuildRequires: perl(Tk::Text) BuildRequires: perl(App::Prove) # Parts of X Window System needed for tests to run: @@ -48,7 +50,7 @@ %check -xinit /usr/bin/make -s test -- /usr/bin/Xvfb :666 |tee testing.TAP +xinit %{_bindir}/make -s test -- %{_bindir}/Xvfb :666 |tee testing.TAP # xinit throws away the return value from make # Let's validate its TAP output ourselves prove --exec cat testing.TAP @@ -66,6 +68,9 @@ %changelog +* Fri Nov 05 2010 Lubomir Rintel (GoodData) <lubo.rintel@xxxxxxxxxxxx> 0.9.4-3 +- Cosmetic fixes + * Wed Nov 03 2010 Lubomir Rintel (GoodData) <lubo.rintel@xxxxxxxxxxxx> 0.9.4-2 - Formatting/wording fixes (Peter Pisar) - Actually run the test suite (Peter Pisar) > FIX: I do not ask to BuildRequire on perl-Tk three times. I ask you to depend > on perl(Tk), perl(Tk::Derived), and perl(Tk::Text). Maintainers of perl-Tk can > decide to split the package into independent subpackages. It's good idea to > depend on each explicit Perl module to prevent future dependency problems. See > output from `rpm -pq --requires'. This is standard way how Perl packages are > maintained in Fedora. If fedora-qa script does not know about it, one should > fix the fedora-qa script and not to break spec files. In other words, > dependencies in Perl should not be expressed by package name, they should be > expressed by Perl module symbolic name (the `perl(FOO)' token). See > <https://fedoraproject.org/wiki/Packaging:Perl#Perl_Requires_and_Provides>. > +BuildRequires: perl(Tk) > +BuildRequires: perl(Tk::Derived) Ok. Package builds in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2579082). Ok. Resolution: Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review