Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=649939 --- Comment #3 from Hans de Goede <hdegoede@xxxxxxxxxx> 2010-11-05 05:35:02 EDT --- Good: - rpmlint checks return: 2 packages and 0 specfiles checked; 0 errors, 0 warnings. - package meets naming guidelines - package meets packaging guidelines - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime Needs work: - All comments from Thomas' comment #1 need to be addressed, wrt to the bytecompiling I would like to add that doing explicit byte compiling from the .spec is never needed as rpmbuild automatically bytecompiles .py files. - This app needs a .desktop file. As already discussed by email, I think you can simply use the standard search icon from the active icon theme for it (usually a spyglass in some form). Simply put the following in the .desktop file: Icon=edit-find You can find all the standardized icon theme icon names here: http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html Usually that is not really a good solution for an apps .desktop file, but since this is a search tool ... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review