Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635450 --- Comment #12 from Hans de Goede <hdegoede@xxxxxxxxxx> 2010-11-05 05:19:45 EDT --- Good: - rpmlint checks return: docky.x86_64: E: no-binary docky.x86_64: W: no-manual-page-for-binary docky docky-devel.x86_64: W: no-documentation These can be ignored - package meets naming guidelines - package meets packaging guidelines - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - properly handles locales - not relocatable - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file properly handled Needs work: - rpmlint checks return: docky.x86_64: E: non-executable-script /usr/lib/python2.7/site-packages/docky/docky.py 0644L /usr/bin/env The problem rpmlint is complaining about here is that docky.py contains a shebang line (#!.... at the top), but is not executable (mode 0644 rather then 0755). Looking at the .py file it is not meant to be directly executed, only to be imported. So the correct solution is too remove the shebang line from the .py file. -/usr/bin/docky has the build system dir embedded in it, in my case: if [ "x$SCRIPT_PATH" = "x/home/hans/rpmbuild/BUILD/docky-2.0.7/Docky/bin/Debug" ] || [ "x$SCRIPT_PATH" = "x/home/hans/rpmbuild/BUILD/docky-2.0.7/Docky" ] ; then echo "*** Running uninstalled ***" DOCKY_EXE="/home/hans/rpmbuild/BUILD/docky-2.0.7/Docky/bin/Debug/Docky.exe" else DOCKY_EXE="/usr/lib64/docky/Docky.exe" fi Please remove this bit from /usr/bin/docky -The disabling of zooming may not be enough if this really is a problem, I'll mail Spot about this and CC you. -I'm not so hot on installing a .desktop file under /etc/xdg/autostart, this means that if this is installed on a system because one user wants to use it, it will autostart for all users. I think this file should not be shipped. -please include NEWS in %doc -The license tag is wrong. Docky is GPLv3+ not GPLv3 and the included gio-sharp.dll is LGPLv2, but that does not need to be mentioned in license as once distributed together the license for the total becomes GPLv3+ gapi_codegen however is a problem, as that is licensed GPLv2, so either the license tag needs to become "GPLv3+ and GPLv2" with a comment that the GPLv2 is for gapi_codegen, or we could remove gapi_codegen from the package, which seems best as I assume this will not be needed during runtime. -Missing Requires: hicolor-icon-theme (for /usr/share/icons/hicolor dir ownership) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review