Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571019 --- Comment #9 from Hans de Goede <hdegoede@xxxxxxxxxx> 2010-11-04 18:12:15 EDT --- Hmm, it seems the .src.rpm is 404 too. Please fix that, I need to src.rpm to complete the review. In the mean time I've done most of the review based on the .spec file: Good: - rpmlint checks return: libmtag.src: W: spelling-error %description -l en_US taglib -> ta glib, ta-glib, tag lib libmtag.src: W: spelling-error %description -l en_US backend -> backed, backbend, back end libmtag.src: W: invalid-url Source0: http://libmtag.googlecode.com/files/libmtag-0.3.5.tar.gz HTTP Error 404: Not Found libmtag.x86_64: W: spelling-error %description -l en_US taglib -> ta glib, ta-glib, tag lib libmtag.x86_64: W: spelling-error %description -l en_US backend -> backed, backbend, back end libmtag-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 6 warnings. All of these rpmlint warnings are bogus, so this is fine. - package meets naming guidelines - package meets packaging guidelines - license (LGPLv2) OK, text in %doc, matches source - spec file legible, in am. english - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Needs work: - source matches upstream I could not verify this because of the lack of a .src.rpm - summary Please drop the An from the summary, as a general rule we try to not have Summaries start with A, An or The. - %doc (main package) Please add README and NEWS to the main package %doc, they seem useful to have around to me. Regards, Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review