Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648266 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2010-11-04 13:23:21 EDT --- Source file original. Ok. License verified from README and lib/CGI/Application/Plugin/JSON.pm. Ok. > BuildRequires: perl(CGI::Application) FIX: Add `>= 4' version constrain to the BuildRequires (META.yml) > BuildRequires: perl(JSON) FIX: Add `>= 2.02' version constrain to the BuildRequires (META.yml) > BuildRequires: perl(JSON::Any) FIX: Add `>= 1.14' version constrain to the BuildRequires (META.yml) All tests pass. Ok. $ rpmlint perl-CGI-Application-Plugin-JSON.spec ../SRPMS/perl-CGI-Application-Plugin-JSON-1.02-1.fc13.src.rpm ../RPMS/noarch/perl-CGI-Application-Plugin-JSON-1.02-1.fc13.noarch.rpm perl-CGI-Application-Plugin-JSON.noarch: E: zero-length /usr/share/doc/perl-CGI-Application-Plugin-JSON-1.02/TODO 2 packages and 1 specfiles checked; 1 errors, 0 warnings. FIX: Do not pack empty TODO file. $ rpm -pq -lv ../RPMS/noarch/perl-CGI-Application-Plugin-JSON-1.02-1.fc13.noarch.rpm drwxr-xr-x 2 root root 0 lis 4 18:03 /usr/share/doc/perl-CGI-Application-Plugin-JSON-1.02 -rw-r--r-- 1 root root 789 dub 8 2009 /usr/share/doc/perl-CGI-Application-Plugin-JSON-1.02/Changes -rw-r--r-- 1 root root 4459 dub 8 2009 /usr/share/doc/perl-CGI-Application-Plugin-JSON-1.02/README -rw-r--r-- 1 root root 0 dub 8 2009 /usr/share/doc/perl-CGI-Application-Plugin-JSON-1.02/TODO -rw-r--r-- 1 root root 3414 lis 4 18:03 /usr/share/man/man3/CGI::Application::Plugin::JSON.3pm.gz drwxr-xr-x 2 root root 0 lis 4 18:03 /usr/share/perl5/CGI drwxr-xr-x 2 root root 0 lis 4 18:03 /usr/share/perl5/CGI/Application drwxr-xr-x 2 root root 0 lis 4 18:03 /usr/share/perl5/CGI/Application/Plugin -rw-r--r-- 1 root root 7192 lis 4 18:03 /usr/share/perl5/CGI/Application/Plugin/JSON.pm File layout and permissions are Ok. $ rpm -pq --requires ../RPMS/noarch/perl-CGI-Application-Plugin-JSON-1.02-1.fc13.noarch.rpm | sort | uniq -c 1 perl(base) 1 perl(CGI::Application) 1 perl(JSON::Any) 1 perl(:MODULE_COMPAT_5.10.1) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rpmlib(VersionedDependencies) <= 3.0.3-1 FIX: Add version to Requires: perl(CGI::Application) and perl(JSON::Any) as stated in META.yml. $ rpm -pq --provides ../RPMS/noarch/perl-CGI-Application-Plugin-JSON-1.02-1.fc13.noarch.rpm | sort | uniq -c 1 perl(CGI::Application::Plugin::JSON) = 1.02 1 perl-CGI-Application-Plugin-JSON = 1.02-1.fc13 Binary provides Ok. Package builds in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2577845). Ok. > + ./Build test > t/00-pod.t ........... ok > t/01-pod-coverage.t .. skipped: Test::Pod::Coverage 1.04 required for testing > POD coverage FIX: BuildRequire perl(Test::Pod::Coverage) >= 1.04 Otherwise package is in line with Fedora and Perl packaging guidelines. Ok. Please correct all `FIX' prefixed issues and submit new spec file. Resolution: Package NOT APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review