Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647149 --- Comment #6 from Paul Howarth <paul@xxxxxxxxxxxx> 2010-11-04 12:51:27 EDT --- >> Patch0: Test-Fatal-0.003-versions.patch >TODO: Post the patch to upstream. Done: https://rt.cpan.org/Public/Bug/Display.html?id=62699 >> -use ExtUtils::MakeMaker 6.31; >> +use ExtUtils::MakeMaker 6.17; >TODO: Put the version to BuildRequires in spec file. This makes RPM backporting into old distribution easier. Not really necessary: this version requirement is met by all current releases including EL-4. >> - 'Test::More' => '0.96', >> + 'Test::More' => '0.47', >TODO: Put the version to BuildRequires in spec file. Again, this requirement is met by all current releases. >> BuildRequires: perl(Test::Pod) >> $ grep -Hnr Test::Pod * >> t/release-pod-syntax.t:12:eval "use Test::Pod 1.41"; >> t/release-pod-syntax.t:13:plan skip_all => "Test::Pod 1.41 required for testing >TODO: Put the version to BuildRequires in spec file. Doing that would prevent builds on older releases purely because we couldn't check the POD syntax during the build, so I don't think that's a good idea. Thanks for the review Petr. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review