Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=647149 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> 2010-11-04 12:29:46 EDT --- Source file original. Ok. License verified from README. Ok. > Patch0: Test-Fatal-0.003-versions.patch TODO: Post the patch to upstream. > -use ExtUtils::MakeMaker 6.31; > +use ExtUtils::MakeMaker 6.17; TODO: Put the version to BuildRequires in spec file. This makes RPM backporting into old distribution easier. > - 'Test::More' => '0.96', > + 'Test::More' => '0.47', TODO: Put the version to BuildRequires in spec file. > BuildRequires: perl(Test::Pod) > $ grep -Hnr Test::Pod * > t/release-pod-syntax.t:12:eval "use Test::Pod 1.41"; > t/release-pod-syntax.t:13:plan skip_all => "Test::Pod 1.41 required for testing TODO: Put the version to BuildRequires in spec file. All tests pass. Ok. $ rpmlint perl-Test-Fatal.spec ../SRPMS/perl-Test-Fatal-0.003-1.fc15.src.rpm ../RPMS/noarch/perl-Test-Fatal-0.003-1.fc15.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint Ok. $ rpm -pq -lv ../RPMS/noarch/perl-Test-Fatal-0.003-1.fc15.noarch.rpm drwxr-xr-x 2 root root 0 lis 4 17:08 /usr/share/doc/perl-Test-Fatal-0.003 -rw-r--r-- 1 root root 379 ÅÃj 29 04:11 /usr/share/doc/perl-Test-Fatal-0.003/Changes -rw-r--r-- 1 root root 18258 ÅÃj 29 04:11 /usr/share/doc/perl-Test-Fatal-0.003/LICENSE -rw-r--r-- 1 root root 324 ÅÃj 29 04:11 /usr/share/doc/perl-Test-Fatal-0.003/README -rw-r--r-- 1 root root 3046 lis 4 17:08 /usr/share/man/man3/Test::Fatal.3pm.gz drwxr-xr-x 2 root root 0 lis 4 17:08 /usr/share/perl5/vendor_perl/Test -rw-r--r-- 1 root root 3355 lis 4 17:08 /usr/share/perl5/vendor_perl/Test/Fatal.pm File layout and permissions Ok. $ rpm -pq --requires ../RPMS/noarch/perl-Test-Fatal-0.003-1.fc15.noarch.rpm | sort | uniq -c 1 perl(Carp) 1 perl(Exporter) >= 5.57 1 perl(:MODULE_COMPAT_5.12.2) 1 perl(strict) 1 perl(Try::Tiny) >= 0.07 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rpmlib(VersionedDependencies) <= 3.0.3-1 $ rpm -pq --provides ../RPMS/noarch/perl-Test-Fatal-0.003-1.fc15.noarch.rpm | sort | uniq -c 1 perl(Test::Fatal) = 0.003 1 perl-Test-Fatal = 0.003-1.fc15 Binary dependencies Ok. Package is in line with Fedora and Perl packaging guidelines. Package builds in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2576674). Ok. Please consider correcting all `TODO' prefixed advises. Resolution: Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review