Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=649662 Michel Alexandre Salim <fedora@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |fedora@xxxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Michel Alexandre Salim <fedora@xxxxxxxxxxxxxxxxxx> 2010-11-04 11:47:35 EDT --- Welcome to the world of Fedora packaging :) A quick initial review: This is a noarch package, so - remove CFLAGS="$RPM_OPT_FLAGS" from %build - you must declare BuildArch: noarch Files in /etc should: - be marked as either %config(noreplace) -- meaning that if the file is changed by the user, on upgrade/reinstall the config file is not touched but the new file saved with a .rpmnew suffix - or marked %config(replace) -- meaning the opposite; old file saved as .rpmsave - use %{_sysconfdir} rather than /etc Also, if you're only targeting Fedora 12 or above, and RHEL 6 or above, BuildRoot is unnecessary. From Fedora 13 and above (alas, no RHEL release yet) the %clean section is also unnecessary; see https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean %python_sitelib declaration is also optional if you only target F-13+ and RHEL 6+: https://fedoraproject.org/wiki/Packaging:Python I'll do an updated review once these are fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review