Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491331 Miroslav Suchà <msuchy@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(msuchy@xxxxxxxxxx | |), | |needinfo?(msuchy@xxxxxxxxxx | |) | --- Comment #10 from Miroslav Suchà <msuchy@xxxxxxxxxx> 2010-11-04 11:12:45 EDT --- >- Incorrect BuildRoot tag. For Fedora it can be omitted and for EPEL5 it should >be one of >http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag >- Should use %global instead of %define >- %description should end with a dot (and could be a little more elaborate). all addressed > - startup.pl and satidmap.pl should be tagged %config or not be in >%{_sysconfdir}. The latter is something that be fixed upstream but not in >packaging. I moved satidmap.pl to /usr/share/rhn. No problem here. But I have problem with startup.pl. It is perl executable. Not configuration file. This is file which mod_perl call during its start. And it always put in apache configuration. I tried to search for some mod_perl aplication in Fedora, but find none. I hesitate to mark this one file as config and also move it to other place. > - Should be GPLv2+. No. It was released as GPLv2. We intentionaly did not released it with "or later" appendix. http://fedoraproject.org/wiki/Licensing#Good_Licenses list GPLv2 as good license. > [/] Package must own all directories that it creates. Addressed. > [/] Package does not contain duplicates in %files Addressed. > Is %{_sharedstatedir}/rhn really not owned by something else? No. On fully installed Spacewalk: # rpm -qf /var/lib/rhn file /var/lib/rhn is not owned by any package Updated SRPM: http://miroslav.suchy.cz/fedora/spacewalk-config/spacewalk-config-1.2.6-1.el6.src.rpm SPEC: http://miroslav.suchy.cz/fedora/spacewalk-config/spacewalk-config.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review