Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=641341 --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> 2010-11-04 06:27:37 EDT --- Spec file changes: --- perl-File-Map.spec 2010-11-04 11:10:18.571439897 +0100 +++ perl-File-Map.spec.1 2010-11-03 19:31:17.000000000 +0100 @@ -1,13 +1,11 @@ Name: perl-File-Map Version: 0.31 -Release: 2%{?dist} +Release: 3%{?dist} Summary: Memory mapping made simple and safe License: GPL+ or Artistic Group: Development/Libraries URL: http://search.cpan.org/dist/File-Map/ Source0: http://www.cpan.org/authors/id/L/LE/LEONT/File-Map-%{version}.tar.gz -Patch0: perl-File-Map-0.31-pod.patch -Patch1: perl-File-Map-0.31-tie.patch BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildRequires: perl >= 0:5.008 BuildRequires: perl(Const::Fast) @@ -18,16 +16,20 @@ BuildRequires: perl(Test::More) BuildRequires: perl(Test::Warn) BuildRequires: perl(Test::Pod::Coverage) +BuildRequires: perl(Test::Pod) >= 1.22 +BuildRequires: perl(IO::Handle) +BuildRequires: perl(Time::Hires) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +%{?perl_default_filter} + %description File::Map maps files or anonymous memory into perl variables. %prep %setup -q -n File-Map-%{version} -%patch0 -p1 -%patch1 -p1 +chmod -x examples/fastsearch.pl %build @@ -62,6 +64,10 @@ %changelog +* Wed Nov 03 2010 Lubomir Rintel (GoodData) <lubo.rintel@xxxxxxxxxxxx> 0.31-3 +- Drop el5 secific patches +- Add more BuildRequires (Petr Pisar) + * Mon Oct 11 2010 Lubomir Rintel (GoodData) <lubo.rintel@xxxxxxxxxxxx> 0.31-2 - Fix build on el5 > > > Patch0: perl-File-Map-0.31-pod.patch > > FIX: This is wrong as the bug is in Test::Pod that has been fixed in 1.41 > > (http://cpansearch.perl.org/src/DWHEELER/Test-Pod-1.41/Changes). No Fedora > > is affected, drop this patch or apply it conditionally on older RHEL > > distributions (if necessary). > > Done. Ok. > > FIX: BuildRequire perl(IO::Handle) (Build.PL and tests) as it can be > > dual-lived package in the future <http://search.cpan.org/~gbarr/IO/>. Ok. > > FIX: BuildRequire perl(Time::Hires) (Build.PL and tests) as it can be > < dual-lived package in the future <http://search.cpan.org/~jhi/Time-HiRes/>. > > Done. > +BuildRequires: perl(Time::Hires) Fix: Proper name is `perl(Time::HiRes)' (capital `R'). I'm sorry I got you wrong name. Use this one please, otherwise the package cannot be built. > > FIX: Remove the private library from provides. You can do that by calling > > `%{?perl_default_filter}' macro right before %description section. See > > <https://fedoraproject.org/wiki/Perl_default_filter>. > > Done. Ok. > > FIX: Remove executable bit from fastsearch.pl. > > Done. Ok. > > > t/pod.t ........... skipped: Test::Pod 1.22 required for testing POD > > FIX: BuildRequire perl(Test::Pod) >= 1.22 > > Done. Ok. FIX: Package does not build in F15 because of perl(Time::HiRes) typo (http://koji.fedoraproject.org/koji/taskinfo?taskID=2576028). Please correct all `FIX' previxed notes and submit new spec file. Resolution: Package NOT APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review