Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635382 --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> 2010-11-04 05:59:27 EDT --- Spec file changes: --- perl-Tk-Text-SuperText.spec 2010-09-19 12:33:20.000000000 +0200 +++ perl-Tk-Text-SuperText.spec.1 2010-11-03 19:16:42.000000000 +0100 @@ -1,6 +1,6 @@ Name: perl-Tk-Text-SuperText Version: 0.9.4 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Improved text widget for perl/tk License: GPL+ or Artistic Group: Development/Libraries @@ -12,12 +12,17 @@ BuildArch: noarch BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(Tk::Text) +BuildRequires: perl(App::Prove) +# Parts of X Window System needed for tests to run: +BuildRequires: xorg-x11-server-Xvfb +BuildRequires: xorg-x11-xinit +BuildRequires: font(:lang=en) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) %description Tk::Text::SuperText implements many new features over the standard Tk::Text -widget while supporting all it's standard features.Its used simply as the -Tk::Text widget. New Features: +widget while supporting all it's standard features. Its used simply as the +Tk::Text widget. %prep @@ -43,12 +48,10 @@ %check -# Test can't be run w/o x11, run them at least -# when developing the package until a mockup/Xvfb is provided -if [ "$DISPLAY" ] -then - make test -fi +xinit /usr/bin/make -s test -- /usr/bin/Xvfb :666 |tee testing.TAP +# xinit throws away the return value from make +# Let's validate its TAP output ourselves +prove --exec cat testing.TAP %clean @@ -63,6 +66,10 @@ %changelog +* Wed Nov 03 2010 Lubomir Rintel (GoodData) <lubo.rintel@xxxxxxxxxxxx> 0.9.4-2 +- Formatting/wording fixes (Peter Pisar) +- Actually run the test suite (Peter Pisar) + * Tue Jun 09 2009 Lubomir Rintel (Good Data) <lubo.rintel@xxxxxxxxxxxx> 0.9.4-1 - Specfile autogenerated by cpanspec 1.78. - Fix up license > > FIX: BuildRequires is missing perl(Tk) and perl(Tk::Derived) (SuperText.pm). > > Tk::Text apparently drags them in. Do you insist on pulling them in? You know, > fedora-qa script would complain that I have unnecessarily duplicate > dependencies if I added them =] FIX: I do not ask to BuildRequire on perl-Tk three times. I ask you to depend on perl(Tk), perl(Tk::Derived), and perl(Tk::Text). Maintainers of perl-Tk can decide to split the package into independent subpackages. It's good idea to depend on each explicit Perl module to prevent future dependency problems. See output from `rpm -pq --requires'. This is standard way how Perl packages are maintained in Fedora. If fedora-qa script does not know about it, one should fix the fedora-qa script and not to break spec files. In other words, dependencies in Perl should not be expressed by package name, they should be expressed by Perl module symbolic name (the `perl(FOO)' token). See <https://fedoraproject.org/wiki/Packaging:Perl#Perl_Requires_and_Provides>. > > FIX: Description miss space after full stop and has dangling `New Features:' > > string. > > Uh, fixed. Ok. > > TODO: The test is never run as modern rpmbuild unset DISPLAY. Consider > > running tests against Xvfb. > > Done. Ok. > +xinit /usr/bin/make -s test -- /usr/bin/Xvfb :666 |tee testing.TAP TODO: It would be nice to replace the `/usr/bin' path with %{__bindir} macro to achieve higher consistency and portability of the spec file. $ rpmlint -i perl-Tk-Text-SuperText.spec ../SRPMS/perl-Tk-Text-SuperText-0.9.4-2.fc13.src.rpm ../RPMS/noarch/perl-Tk-Text-SuperText-0.9.4-2.fc13.noarch.rpm perl-Tk-Text-SuperText.spec:19: W: comparison-operator-in-deptoken font(:lang=en) This dependency token contains a comparison operator (<, > or =). This is usually not intended and may be caused by missing whitespace between the token's name, the comparison operator and the version string. perl-Tk-Text-SuperText.src:19: W: comparison-operator-in-deptoken font(:lang=en) This dependency token contains a comparison operator (<, > or =). This is usually not intended and may be caused by missing whitespace between the token's name, the comparison operator and the version string. 2 packages and 1 specfiles checked; 0 errors, 2 warnings. This is spurious warning because of `font(:lang=en)'. Ok. Package builds in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2575964). Ok. Please correct all `FIX' prefixed issues and provide new spec file. Resolution: Package NOT APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review