Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491331 --- Comment #8 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2010-11-03 21:27:51 EDT --- (In reply to comment #5) > [/] Package meets the Packaging Guidelines including the Language specific > items - Incorrect BuildRoot tag. For Fedora it can be omitted and for EPEL5 it should be one of http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag - Should use %global instead of %define - %description should end with a dot (and could be a little more elaborate). - startup.pl and satidmap.pl should be tagged %config or not be in %{_sysconfdir}. The latter is something that be fixed upstream but not in packaging. > [/] License field in the package spec file matches the actual license. > License type: GPLv2 - Should be GPLv2+. If no version of the license is specified, then it usually means "or any later versions", see section 9 of the GPLv2. > [/] Package must own all directories that it creates. But it doesn't: %{_sysconfdir}/pki/tls/ %{_sysconfdir}/pki/tls/certs/ %{_sysconfdir}/pki/tls/private/ %{_var}/lib/cobbler/ %{_var}/lib/cobbler/kickstarts/ %{_var}/lib/cobbler/snippets/ are not owned by this package or one of it's requirements. And %{_var}/lib/ should be %{_sharedstatedir}. > [/] Package does not contain duplicates in %files. It does: warning: File listed twice: /var/lib/rhn/rhn-satellite-prep warning: File listed twice: /var/lib/rhn/rhn-satellite-prep/etc warning: File listed twice: /var/lib/rhn/rhn-satellite-prep/etc/rhn warning: File listed twice: /var/lib/rhn/rhn-satellite-prep/etc/rhn/cluster.ini warning: File listed twice: /var/lib/rhn/rhn-satellite-prep/etc/rhn/rhn.conf %{prepdir} is a subdirectory %{_sharedstatedir}/rhn > [/] Permissions on files are set properly > [/] %files section includes a %defattr(...) line > [/] Package consistently uses macros. > [/] Package does not own files or directories owned by other packages. Is %{_sharedstatedir}/rhn really not owned by something else? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review