[Bug 645764] Review Request: django-addons - to add plugging functionality in your projects easier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645764

--- Comment #8 from Domingo Becker <domingobecker@xxxxxxxxx> 2010-11-03 17:55:43 EDT ---
(In reply to comment #5)
> Much better :) 
> 
> As is, it won't build in mock, you need to add Django to BuildRequires.
> 

Added.

> Then it will build at least in F14 and EPEL6, but not on EPEL5, where
> python-setuptools-devel does not exist; if you're not going to ask for a EL5
> branch you may ignore the issue.
> 

I guess it will be F14 or EPEL6.

> the LICENSE file needs to be added to %doc, along with README or PKG-INFO (the
> least two seem to have basically the same content)
> 

This has not been done yet.

> rpmlint is not clean; some items will go away but I think:
> django-addons.noarch: W: non-standard-dir-in-usr django_addons
> 
> needs to be addressed.
> 
> Is there a reason why that directory is not in /usr/share ?

I asked upstream about this issue.


(In reply to comment #6)
> Ah, forgot a couple more points.
> 
> URL should be simple the reference to the project website, like this:
> URL:            http://pypi.python.org/pypi/django-addons
> 

Fixed.

> It's a SHOULD item but please add a comment in the spec about the added patch;
> if you reported it upstream, a link to an open issue or even a mailing list
> message is just enough, see:
> 
> https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

Fixed. An email has been sent.

Current django-addons.spec and patch with new file name are in

Spec URL: http://beckerde.fedorapeople.org/transifex/django-addons.spec
Patch URL:
http://beckerde.fedorapeople.org/transifex/django-addons-rm-bad-string.diff
SRPM URL:
http://beckerde.fedorapeople.org/transifex/django-addons-0.6.2-1.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]