Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=641341 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> 2010-11-03 12:52:07 EDT --- The standalone spec file and the embedded one in SRPM differ. I will use the standalone one for reference. Source tar ball is original. Ok. > Patch0: perl-File-Map-0.31-pod.patch FIX: This is wrong as the bug is in Test::Pod that has been fixed in 1.41 (http://cpansearch.perl.org/src/DWHEELER/Test-Pod-1.41/Changes). No Fedora is affected, drop this patch or apply it conditionally on older RHEL distributions (if necessary). TODO: Submit the perl-File-Map-0.31-tie.patch patches to upstream. License verified from README and lib/File/Map.pm. Ok. FIX: BuildRequire perl(IO::Handle) (Build.PL and tests) as it can be dual-lived package in the future <http://search.cpan.org/~gbarr/IO/>. FIX: BuildRequire perl(Time::Hires) (Build.PL and tests) as it can be dual-lived package in the future <http://search.cpan.org/~jhi/Time-HiRes/>. All tests pass. Ok. $ rpmlint perl-File-Map.spec ../SRPMS/perl-File-Map-0.31-2.fc15.src.rpm ../RPMS/x86_64/perl-File-Map-0.31-2.fc15.x86_64.rpm perl-File-Map.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/File/Map/Map.so Map.so()(64bit) perl-File-Map.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/File/Map/Map.so Map.so()(64bit) perl-File-Map.x86_64: W: spurious-executable-perm /usr/share/doc/perl-File-Map-0.31/examples/fastsearch.pl perl-File-Map.x86_64: W: doc-file-dependency /usr/share/doc/perl-File-Map-0.31/examples/fastsearch.pl /usr/bin/perl 2 packages and 1 specfiles checked; 0 errors, 4 warnings. FIX: Remove the private library from provides. You can do that by calling `%{?perl_default_filter}' macro right before %description section. See <https://fedoraproject.org/wiki/Perl_default_filter>. FIX: Remove executable bit from fastsearch.pl. $ rpm -pq -lv ../RPMS/x86_64/perl-File-Map-0.31-2.fc15.x86_64.rpm drwxr-xr-x 2 root root 0 Nov 3 17:16 /usr/lib64/perl5/vendor_perl/File -rw-r--r-- 1 root root 15566 Nov 3 17:16 /usr/lib64/perl5/vendor_perl/File/Map.pm drwxr-xr-x 2 root root 0 Nov 3 17:16 /usr/lib64/perl5/vendor_perl/auto/File drwxr-xr-x 2 root root 0 Nov 3 17:16 /usr/lib64/perl5/vendor_perl/auto/File/Map -rwxr-xr-x 1 root root 28760 Nov 3 17:16 /usr/lib64/perl5/vendor_perl/auto/File/Map/Map.so drwxr-xr-x 2 root root 0 Nov 3 17:16 /usr/share/doc/perl-File-Map-0.31 -rw-r--r-- 1 root root 4818 Sep 20 17:15 /usr/share/doc/perl-File-Map-0.31/Changes -rw-r--r-- 1 root root 17979 Sep 20 17:15 /usr/share/doc/perl-File-Map-0.31/LICENSE -rw-r--r-- 1 root root 2292 Sep 20 17:15 /usr/share/doc/perl-File-Map-0.31/README drwxr-xr-x 2 root root 0 Sep 20 17:15 /usr/share/doc/perl-File-Map-0.31/examples -rwxr-xr-x 1 root root 355 Sep 20 17:15 /usr/share/doc/perl-File-Map-0.31/examples/fastsearch.pl -rw-r--r-- 1 root root 6899 Nov 3 17:16 /usr/share/man/man3/File::Map.3pm.gz File layout Ok. Permissions except the fastsearch.pl Ok. $ rpm -pq --requires ../RPMS/x86_64/perl-File-Map-0.31-2.fc15.x86_64.rpm |sort |uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.2)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 perl >= 0:5.008 1 perl >= 1:5.010 1 perl(Carp) 1 perl(Const::Fast) 1 perl(File::Map) 1 perl(:MODULE_COMPAT_5.12.2) 1 perl(PerlIO) 1 perl(strict) 1 perl(Sub::Exporter) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rpmlib(VersionedDependencies) <= 3.0.3-1 1 rtld(GNU_HASH) 1 /usr/bin/perl Binary requires Ok. $ rpm -pq --provides ../RPMS/x86_64/perl-File-Map-0.31-2.fc15.x86_64.rpm |sort |uniq -c 1 Map.so()(64bit) 1 perl(File::Map) = 0.31 1 perl-File-Map = 0.31-2.fc15 1 perl-File-Map(x86-64) = 0.31-2.fc15 FIX: Remove the Map.so() as stated in rpmlint. Package builds in F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2574507). Ok. > t/pod.t ........... skipped: Test::Pod 1.22 required for testing POD FIX: BuildRequire perl(Test::Pod) >= 1.22 Otherwise, package is in line with Fedora and Perl packaging guildelines. Please correct all `FIX' prefixed lines and submit new spec file. Resolution: Package NOT APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review