[Bug 630681] Review Request: lasem - SVG and MathML rendering library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=630681

Orion Poplawski <orion@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |orion@xxxxxxxxxxxxx

--- Comment #3 from Orion Poplawski <orion@xxxxxxxxxxxxx> 2010-11-03 11:56:51 EDT ---
(In reply to comment #1)
> >lasem.x86_64: W: shared-lib-calls-exit /usr/lib64/liblasem-0.4.so.3.0.0 exit@xxxxxxxxxxx
> 
> It says by itself, needs to be fixed.
> 

$ rpmlint -I shared-lib-calls-exit
shared-lib-calls-exit:
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.

--

My take - while upstream should be contacted and exit() probably should be
removed, this is not a blocker.

> >lasem-tools.x86_64: W: no-manual-page-for-binary lasemrender
> 
> Try to follow https://fedoraproject.org/wiki/Packaging:Guidelines#Man_pages, if
> possible.

Same here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]