Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644135 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #2 from Hans de Goede <hdegoede@xxxxxxxxxx> 2010-11-03 10:53:21 EDT --- Full review done: Good: - rpmlint checks return: miglayout.noarch: W: no-documentation miglayout-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Javanese 4 packages and 0 specfiles checked; 0 errors, 2 warnings. These can all be ignored - package meets naming guidelines - package meets packaging guidelines - license (BSD) OK, text not in %doc, but that is normal for BSD, all source files do have BSD copyright headers - spec file legible, in am. english - source matches upstream - package compiles on f14 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - javadocs in -javadoc subpackage - nothing in %doc affects runtime - no need for .desktop file Now that is how easy all reviews should be, this is one well done package :) APPROVED! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review