Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637491 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2010-11-03 10:21:49 EDT --- Source tar ball original. Ok. License verified from README and lib/Params/Classify.pm. Ok. FIXME: BuildRequire perl(Scalar::Util) >= 1.1 as it can be dual-live package in the future (http://search.cpan.org/~gbarr/Scalar-List-Utils/) > %{__perl} Build.PL installdirs=vendor optimize="%{optimize}" What's the `optimize' macro and argument? All tests pass. Ok. $ rpmlint perl-Params-Classify.spec ../SRPMS/perl-Params-Classify-0.011-1.fc13.src.rpm ../RPMS/x86_64/perl-Params-Classify-0.011-1.fc13.x86_64.rpm perl-Params-Classify.spec: W: no-cleaning-of-buildroot %clean perl-Params-Classify.spec: W: no-buildroot-tag perl-Params-Classify.spec: W: no-%clean-section perl-Params-Classify.src: W: no-cleaning-of-buildroot %clean perl-Params-Classify.src: W: no-buildroot-tag perl-Params-Classify.src: W: no-%clean-section 2 packages and 1 specfiles checked; 0 errors, 6 warnings. This is post-F11 spec. Ok. $ rpm -pq -lv ../RPMS/x86_64/perl-Params-Classify-0.011-1.fc13.x86_64.rpm drwxr-xr-x 2 root root 0 lis 3 15:11 /usr/lib64/perl5/Params -rw-r--r-- 1 root root 15056 lis 3 15:11 /usr/lib64/perl5/Params/Classify.pm drwxr-xr-x 2 root root 0 lis 3 15:11 /usr/lib64/perl5/auto/Params drwxr-xr-x 2 root root 0 lis 3 15:11 /usr/lib64/perl5/auto/Params/Classify -rwxr-xr-x 1 root root 23376 lis 3 15:11 /usr/lib64/perl5/auto/Params/Classify/Classify.so drwxr-xr-x 2 root root 0 lis 3 15:11 /usr/share/doc/perl-Params-Classify-0.011 -rw-r--r-- 1 root root 3989 srp 21 12:27 /usr/share/doc/perl-Params-Classify-0.011/Changes -rw-r--r-- 1 root root 1546 srp 21 12:27 /usr/share/doc/perl-Params-Classify-0.011/README -rw-r--r-- 1 root root 5712 lis 3 15:11 /usr/share/man/man3/Params::Classify.3pm.gz File layout and permissions Ok. $ rpm -pq --requires ../RPMS/x86_64/perl-Params-Classify-0.011-1.fc13.x86_64.rpm | sort | uniq -c 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6()(64bit) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.10.1) 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 2 rpmlib(VersionedDependencies) <= 3.0.3-1 1 rtld(GNU_HASH) $ rpm -pq --provides ../RPMS/x86_64/perl-Params-Classify-0.011-1.fc13.x86_64.rpm | sort | uniq -c 1 perl-Params-Classify(x86-64) = 0.011-1.fc13 1 perl(Params::Classify) = 0.011 1 perl-Params-Classify = 0.011-1.fc13 Binary dependencies Ok. Spec file is in line with Fedora and Perl packaging guidelines. Package builds in F15 <http://koji.fedoraproject.org/koji/taskinfo?taskID=2574063>. Ok. > t/pod_cvg.t ...... skipped: Test::Pod::Coverage not available > t/pod_cvg_pp.t ... skipped: Test::Pod::Coverage not available > t/pod_syn.t ...... skipped: Test::Pod not available FIX: BuildRequire perl(Test::Pod) and perl(Test::Pod::Coverage). Please correct all `FIX' prefixed issues and submit new spec file. Please explain the `optimize' statement. Resolution: Package NOT APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review