Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635382 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2010-11-03 09:09:52 EDT --- Source tar ball is original. Ok. License verified from README. Ok. FIX: BuildRequires is missing perl(Tk) and perl(Tk::Derived) (SuperText.pm). FIX: Description miss space after full stop and has dangling `New Features:' string. TODO: The test is never run as modern rpmbuild unset DISPLAY. Consider running tests against Xvfb. $ rpmlint perl-Tk-Text-SuperText.spec ../SRPMS/perl-Tk-Text-SuperText-0.9.4-1.fc13.src.rpm ../RPMS/noarch/perl-Tk-Text-SuperText-0.9.4-1.fc13.noarch.rpm perl-Tk-Text-SuperText.spec:50: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 50) perl-Tk-Text-SuperText.src:50: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 50) 2 packages and 1 specfiles checked; 0 errors, 2 warnings. FIX: expand tabs to spaces in the spec file. $ rpm -pq -lv ../RPMS/noarch/perl-Tk-Text-SuperText-0.9.4-1.fc13.noarch.rpm drwxr-xr-x 2 root root 0 lis 3 10:40 /usr/share/doc/perl-Tk-Text-SuperText-0.9.4 -rw-r--r-- 1 root root 1524 led 17 2001 /usr/share/doc/perl-Tk-Text-SuperText-0.9.4/README -rw-r--r-- 1 root root 5614 lis 3 10:40 /usr/share/man/man3/Tk::Text::SuperText.3pm.gz drwxr-xr-x 2 root root 0 lis 3 10:40 /usr/share/perl5/Tk drwxr-xr-x 2 root root 0 lis 3 10:40 /usr/share/perl5/Tk/Text -rw-r--r-- 1 root root 56195 lis 3 10:40 /usr/share/perl5/Tk/Text/SuperText.pm drwxr-xr-x 2 root root 0 lis 3 10:40 /usr/share/perl5/auto drwxr-xr-x 2 root root 0 lis 3 10:40 /usr/share/perl5/auto/Tk drwxr-xr-x 2 root root 0 lis 3 10:40 /usr/share/perl5/auto/Tk/Text drwxr-xr-x 2 root root 0 lis 3 10:40 /usr/share/perl5/auto/Tk/Text/SuperText -rw-r--r-- 1 root root 96 lis 3 10:40 /usr/share/perl5/auto/Tk/Text/SuperText/autosplit.ix Files layout and permissions Ok. $ rpm -pq --requires ../RPMS/noarch/perl-Tk-Text-SuperText-0.9.4-1.fc13.noarch.rpm | sort | uniq -c 1 perl(AutoLoader) 1 perl(Carp) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.10.1) 1 perl(strict) 1 perl(Tk) 1 perl(Tk::Derived) 1 perl(Tk::Text) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rpmlib(VersionedDependencies) <= 3.0.3-1 $ rpm -pq --provides ../RPMS/noarch/perl-Tk-Text-SuperText-0.9.4-1.fc13.noarch.rpm | sort | uniq -c 1 perl(Tk::Text::SuperText) = 0.9.4 1 perl-Tk-Text-SuperText = 0.9.4-1.fc13 Binary dependencies Ok. Package builds in F-15 successfully (http://koji.fedoraproject.org/koji/taskinfo?taskID=2573801). Ok. Spec file is in line with Fedora and Perl packaging guidelines. Ok. Please fix all issues prefixed with `FIX' and submit new spec file. Consider implementing all `TODO' prefixed sections. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review