Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alsa-tools - Specialist tools for ALSA https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217256 ------- Additional Comments From rpm@xxxxxxxxxx 2006-11-27 17:31 EST ------- Many thanks for the review Parag. I left the version at 1.0.12 to match the version of alsa-libs currently included with FC6. Linus, I'm not 100% sure whether including your script is appropriate or not. In one way, I think it should be in a separate package (e.g. alsa-opl3 or something) but that seems complete overkill for a 4 line script. On the other hand it is kind of appropriate to put it here given that alsa-tools includes the sbiload binary. If we did include it I'm not sure what I would call the init script. "alsa-tools" seems wrong. "alsa-tools-opl3" is OK, but a bit of chkconfig clutter. Parag, do you have any comments? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review