Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=638590 --- Comment #3 from Andrea Musuruane <musuruan@xxxxxxxxx> 2010-11-02 09:58:25 EDT --- I have a quick glance. There are some things to fix: * The release in the Release tag and in the Changelog do not match. * The release scheme used is wrong: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages * You must have a 'Requires: hicolor-icon-theme', which owns the %{_datadir}/icons/hicolor directory. * Since the .desktop file has a MimeType key, and you are installing icons in %{_datadir}/icons/hicolor, you need to use the appropriate scriptlets. See: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database and https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache * You are missing Java minimum BuildRequires and Requires: https://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires * Why the package is not marked as NoArch? * HotEqn is still required in the wrapper script. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review